Skip to content

Error from Phpactor when importing class #816

Closed

Description

@fcojavierdomenech

I've recently done a PlugUpdate and received last changes, until now I could import a class positioning the cursor-> menu->im(p)ort, now it's giving me the following error:

Key(s) "name" are not known, known keys: "qualified_name", "alias", "offset", "source", "path"

Although I still call import when auto-completing a class.

Activity

  1. dantleech commented on Sep 5, 2019

    @dantleech
    Collaborator

    Oops, yes this is a regression.

  2. dantleech commented on Sep 5, 2019

    @dantleech
    Collaborator

    I have added a fix to master, can you verify?

  3. fcojavierdomenech commented on Sep 5, 2019

    @fcojavierdomenech
    ContributorAuthor

    Sure, I've updated again and now works perfectly. Thanks a lot!

  4. fcojavierdomenech commented on Sep 6, 2019

    @fcojavierdomenech
    ContributorAuthor

    Sorry, I did a quick check and worked but in fact there is still some kind of bug going on.

    As I said now it imports, but it does at the same namespace, not the real one.

    For instance, one of my domains, Booking.
    Importing with the cursor-> menu->im(p)ort does a:

    use Booking;

    while the autocompletion import (this works fine):

    use Api\Service\Booking\Domain\Booking;

  5. added a commit that references this issue on Sep 6, 2019
  6. dantleech commented on Sep 6, 2019

    @dantleech
    Collaborator

    Doh, have updated master again -- 🤞 -- planning to refactor the context menu, but really shows up where the tests are missing ...

  7. fcojavierdomenech commented on Sep 7, 2019

    @fcojavierdomenech
    ContributorAuthor

    Importing from menu now works, except when you are positioned at the last char of the word. In that case an error message shows No classes found with name " ". This was working before (I use your software every working day!).

  8. einenlum commented on Sep 13, 2019

    @einenlum
    Collaborator

    Same note here. I switched a few days ago to develop and it's amazing except this regression: not possible to use a class when we are on the last char (worked before). Same message as @vivoconunxino : No classes found with name " ".

  9. added a commit that references this issue on Sep 13, 2019
    513ca60
  10. dantleech commented on Sep 13, 2019

    @dantleech
    Collaborator

    Fixed in phpactor/text-document@053f321 and updated in develop, will hopefully that's fine and I'll make tag a new version of text-document and update master.

  11. dantleech commented on Sep 13, 2019

    @dantleech
    Collaborator

    Master has been updated.

  12. added a commit that references this issue on Mar 1, 2020
  13. added a commit that references this issue on May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions