You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
VimPlugin - Use fzf as replacement for inputlist #768
First of all, thanks for all the work done!
I really felt in love with PHPActor and it's a really nice tool to have on a daily basis.
My problem here is with the inputlist() used in the vim plugin to choose the method to override.
If you wonder what I mean, just open the first PHPUnit TestCases you got in your project and try to override a method.
The list is so long that tne inputlist() function provided by Vim is not really suited for the task.
I already have implemented a working solution on my fork, but it needed some important modifications.
The main problem is that I didn't managed to make fzf work synchronously, so I had to rewrite the input callback of the vim plugin.
Instead of calling it for every input the user will have to provide and returning the result every time, I implemented a system which looks like middlewares.
For every input, you gave it the next thing to do.
Which would be handle the next input or call the RPC.
Let me know what you think about it or if you have over ideas in mind.
One more thing I appreciate about fzf is the possibility to select multiple items in the list (not implemented in the branch).
So we could also imagine be able to override multiple methods at one.
Integrate it to the "add missing properties", "implements interface methods" functionalities.
Interesting! FZF would indeed be much better here, and what you have seems to work well - would be nice to fallback to InputList if FZF is not available however.
Could you make a PR and we can look into it further?
Activity
dantleech commentedon May 30, 2019
Interesting! FZF would indeed be much better here, and what you have seems to work well - would be nice to fallback to InputList if FZF is not available however.
Could you make a PR and we can look into it further?
camilledejoye commentedon May 30, 2019
Not a problem, and I will check for the fallback.
I thought I already did it...
dantleech commentedon May 31, 2019
#769 is merged, thanks again for the effort :)