You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
phpactor does not understand nullable return typehints #753
Activity
dantleech commentedon Apr 16, 2019
Yeah, this is a missing feature :) This is the offending code:
https://github.com/phpactor/code-transform/blob/master/lib/Adapter/WorseReflection/GenerateFromExisting/InterfaceFromExistingGenerator.php
Not sure if the underlying code generation (https://github.com/phpactor/code-builder) supports nullable types yet.
einenlum commentedon May 20, 2019
Seems that the Type class in the worse-reflection repo should also be changed to allow nullable: https://github.com/phpactor/worse-reflection/blob/master/lib/Core/Type.php
dantleech commentedon Jun 14, 2019
Made a (quick) attempt at this phpactor/worse-reflection#55 still needs parameter support.