Skip to content

[code-transform] Override method requires class to be saved before new parent considered #733

Closed

Description

@dantleech

When overriding a method on a class, which on disk, has no parent, but in the editor now extends another class, Phpactor reports that the class has no parent. But it should consider the class in the editor buffer, not the one on disk.

Activity

  1. dantleech commented on Feb 3, 2019

    @dantleech
    CollaboratorAuthor

    Because the Refectoring class reflects the class directly instead of from the source code, but in which case this should also not work in master

  2. changed the title [-][develop regression?] Override method requires class to be saved before new parent considered[/-] [+][code-transform] Override method requires class to be saved before new parent considered[/+] on Feb 3, 2019
  3. added a commit that references this issue on Mar 3, 2019
  4. added a commit that references this issue on May 18, 2019
  5. added a commit that references this issue on Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions