You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[completion] Change API to accept a SourceCode V/O #665
The completion API currently accepts a string $sourceCode, int $offset, however it is necessary in some cases that the file path of the source code also be known (for example to let the reflection system process requires / includes etc).
Changing the method signature to SourceCode $sourceCode (and possibly Offset) would probably be best.
The SourceCode V/O is re-implemented in many of Phpactor's libraries, so it may be worth extracting it to a shared lib.
Activity
dantleech commentedon Dec 21, 2018
Should replace it with text-document
dantleech commentedon Jan 17, 2019
Done...