Skip to content

[completion] Change API to accept a SourceCode V/O #665

Closed

Description

@dantleech

The completion API currently accepts a string $sourceCode, int $offset, however it is necessary in some cases that the file path of the source code also be known (for example to let the reflection system process requires / includes etc).

Changing the method signature to SourceCode $sourceCode (and possibly Offset) would probably be best.

The SourceCode V/O is re-implemented in many of Phpactor's libraries, so it may be worth extracting it to a shared lib.

Activity

  1. dantleech commented on Dec 21, 2018

    @dantleech
    CollaboratorAuthor

    Should replace it with text-document

  2. dantleech commented on Jan 17, 2019

    @dantleech
    CollaboratorAuthor

    Done...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions