Skip to content

Support @var TypeHere without var name #618

Closed

Description

@kermorgant

image

With the cursor on getUserId, invoking find-references only returns one result, corresponding to this definition (using phpactor 0.9.0)

Looks like the annotation was not taken into account, or is it something else ?

Here's a bit of output from the replay

[2018-10-22 18:35:07] phpactor.DEBUG: RESPONSE {"action":"collection","parameters":{"actions":[{"name":"echo","parameters":{"message":"Found 1 literal references to method \"getUserId\" using FS \"git\""}},{"name":"file_references","parameters":{"file_references":[{"file":"/home/mikael/workspace/lmt/project/src/AppBundle/Application/User/UserCompleteProfileWasUpdated.php","references":[{"start":"Over 9 levels deep, aborting normalization","end":"Over 9 levels deep, aborting normalization","line_no":"Over 9 levels deep, aborting normalization","col_no":"Over 9 levels deep, aborting normalization"}]}]}}]}} []                         
{"version":"1.0.0","action":"collection","parameters":{"actions":[{"name":"echo","parameters":{"message":"Found 1 literal references to method \"getUserId\" using FS \"git\""}},{"name":"file_references","parameters":{"file_references":[{"file":"\/home\/mikael\/workspace\/lmt\/project\/src\/AppBundle\/Application\/User\/UserCompleteProfileWasUpdated.php","references":[{"start":359,"end":368,"line_no":18,"col_no":20}]}]}}]}}

Activity

  1. dantleech commented on Oct 22, 2018

    @dantleech
    Collaborator

    Yeah, the annotation currently needs to explicitly indicate the var name e.g. var Foobar $foobar

    Would probably not be very hard to support this though..

  2. changed the title [-]find references for class member failure[/-] [+]Support @var TypeHere without var name[/+] on Dec 21, 2018
  3. dantleech commented on Dec 22, 2018

    @dantleech
    Collaborator

    Fixed in #680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions