Skip to content

Jump list has intermediary, unwanted item #1213

Open

Description

@greg0ire

When using :PhpactorGotoDefinition, the jump list seems to have an extra item matching the first line of the destination file. This is a bug I remember having for quite some time, never bothered reporting it until now but it does seem to be related to phpactor because using the native tags-based <C-]> does not produce that bug.

For instance, in doctrine/orm:
vi tests/Doctrine/Tests/ORM/Functional/NativeQueryTest.php
44j$bb:clearjumps<CR>:PhpactorGotoDefinition<CR><C-O>:jumps will show the issue

Peek 2021-02-21 10-35

Activity

  1. camilledejoye commented on Mar 8, 2021

    @camilledejoye
    Contributor

    Indeed this is an issue with the vim plugin, it was first fixed with #828 and #837
    I think it was broke around #893

    If I recall properly this extra jump is added whenever we open a file that was not already open in vim.
    We need to identify when vim add this extra jump and remove it to preserve the user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions