Skip to content

[BC break] Introduced in Phpactor\Container\Extension #1194

Closed

Description

@camilledejoye
PHP Fatal error:  Declaration of Phpactor\Extension\PhpSpec\PhpSpecExtension::load(Phpactor\Container\ContainerBuilder $container) must be compatible with Phpactor\Container\Extension::load(Phpactor\Container\ContainerBuilder $container): void in /home/cdejoye/work/phpactor/extensions/phpactor/phpspec-extension/lib/PhpSpecExtension.php on line 19

A recent change was to add a void return type for the two methods defined in this interface.
On my side the PHPUnit and PHPSpec extension were not updated, causing phpactor to crash.

Activity

  1. dantleech commented on Feb 1, 2021

    @dantleech
    Collaborator

    yes - updating them will fix the issue (may need to manually manipulate the files in extensions). can't currently think of another solution, maybe a composer hook ? 🤔

  2. dantleech commented on Feb 1, 2021

    @dantleech
    Collaborator

    Added a post install hook in #1195, i think that should help.

  3. camilledejoye commented on Feb 4, 2021

    @camilledejoye
    ContributorAuthor

    Great, sorry for not responding earlier but it's crazy currently for me all the things I have to do...
    I thought about updating the dependencies and proposing a hook in composer too indeed. Just too painful to deal with the extensions manually :)

    Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions