Skip to content

RPC Open File regression via. #987 #1136

Closed

Description

@dantleech

Introduced in #987

When using :PhpactorNavigate we get the following error:

image

Due to the Phpactor\Extension\Rpc\Response\OpenFileResponse:

    const TARGET_FOCUSED_WINDOW = 'focused_window';
    const TARGET_VERTICAL_SPLIT = 'vsplit';
    const TARGET_HORIZONTAL_SPLIT = 'hsplit';
    const TARGET_NEW_TAB = 'new_tab';

Updating the targets however causes another problem:

Error detected while processing function phpactor#Navigate[1]..phpactor#rpc[24]..phpactor#_rpc_dispatch[124]..phpactor#_rpc_dispatch_input[43]..phpactor#input#choice[30]..phpactor#_rpc_dispatc
h_input_handler[3]..phpactor#rpc[24]..phpactor#_rpc_dispatch[56]..<SNR>164_openFileInSelectedTarget:
line   24:
E481: No range allowed: 0 edit spec/xxx/Bundle/StoreBundle/Mailer/Sender/SenderSpec.php
Error detected while processing function phpactor#Navigate[1]..phpactor#rpc:
line   24:
E171: Missing :endif

Activity

  1. dantleech commented on Dec 1, 2020

    @dantleech
    CollaboratorAuthor
  2. camilledejoye commented on Dec 1, 2020

    @camilledejoye
    Contributor

    I'll try to look into it today

  3. dantleech commented on Dec 1, 2020

    @dantleech
    CollaboratorAuthor

    cool thanks, if you don't get a chance today I'll try and investigate myself or revert the PR temporarily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions