You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Still same problems, this is the phpactor status command from console:
phpactor [develop] % phpactor status
Version: 12cd699 (30 hours ago) 2020-06-13-1077
Filesystems: git, simple, composer
Working directory: /home/vivo/phpactor
Config files (missing is not bad):
✘ /home/vivo/.config/phpactor/phpactor.json
✘ /home/vivo/.config/phpactor/phpactor.yml
✘ /home/vivo/phpactor/.phpactor.json
✘ /home/vivo/phpactor/.phpactor.yml
Diagnostics:
✔ Composer detected - Phpactor could work faster without an index
✔ Git detected - enables faster refactorings in your repository scope!
✔ XDebug is disabled. XDebug has a negative effect on performance.
Now I'm not getting the Starting LS languageserver.phpactor message, but it's not working yet. (i.e getting [coc.nvim] Definition provider not found for current document when going to definition), also where can I find that doc about the settings you have? Sorry if I'm asking dumb questions, but I did not see it anywere while looking how to install it.
:CocInfo seems to do nothing since we put phpactor.enable and phpactor.path on the root settings instead of the initial "languageserver": {"phpactor": { etc`
## versions
vim version: NVIM v0.5.0-553-gd8c5d122f
node version: v12.18.0
coc.nvim version: 0.0.78-9248f43d6c
coc.nvim directory: /home/vivo/.vim/plugged/coc.nvim
term: xterm-256color
platform: linux
I just tried your final settings and everything works :)
Regarding the :CocConfig I just tried to replicate the ones of the README of nvim coc, I tried a few things before from here without success:
...
You have to install coc extension or configure language servers for LSP support.
Install extensions like:
:CocInstall coc-json coc-tsserver
Or configure language server in coc-settings.json opened by :CocConfig, like:
{
"languageserver": {
"go": {
"command": "gopls",
"rootPatterns": ["go.mod"],
"trace.server": "verbose",
"filetypes": ["go"]
}
}
}
...
Well, to be fair it was my first coc extension ever. But I agree with documenting it.
I dunno why coc-phpactor failed in my case, are there any more logs I can pass you?
Anyway, it's working :) Thanks!
Activity
fcojavierdomenech commentedon Jun 14, 2020
:CocInfodantleech commentedon Jun 14, 2020
With the Phpactor COC extension you don't need to configure the language server, just
phpactor.enablein:CocConfigdantleech commentedon Jun 14, 2020
My
:CocConfighas only:relating to Phpactor.
Also, Phpactor might be crashing (the
Connection to server got closed). Maybe try runningphpactor statusfrom the CLI?fcojavierdomenech commentedon Jun 14, 2020
Ok, now I tried this coc-settings.json based on yours:
Still same problems, this is the
phpactor statuscommand from console:dantleech commentedon Jun 14, 2020
The config is at the root level - my config is f.e. something like:
(included the empty
languageserverkey for illustration)fcojavierdomenech commentedon Jun 14, 2020
I just tried with this coc-settings:
Now I'm not getting the
Starting LS languageserver.phpactormessage, but it's not working yet. (i.e getting[coc.nvim] Definition provider not found for current documentwhen going to definition), also where can I find that doc about the settings you have? Sorry if I'm asking dumb questions, but I did not see it anywere while looking how to install it.dantleech commentedon Jun 14, 2020
What if you do
:CocCommand phpactor.status?fcojavierdomenech commentedon Jun 14, 2020
I get an error:
[coc.nvim] Command: phpactor.status not foundTrying more things, I installed intelliphense and autocompletion and goToDefinition started working...
Currently I disabled it so I can try phpactor as I told you, these are the list of settings (coc-phpactor is installed!) :/
dantleech commentedon Jun 14, 2020
Anything different in
:CocInfo? does it attempt to start the language server?I see only:
fcojavierdomenech commentedon Jun 14, 2020
:CocInfoseems to do nothing since we put phpactor.enable and phpactor.path on the root settings instead of the initial"languageserver": {"phpactor": {etc`If I put the
then I still have the same output from #1078 (comment)
dantleech commentedon Jun 14, 2020
well -- both should work.
so, one more thing you can try - in a separate terminal:
and then set
phpactor.enabletofalse(optionally) and set the followinglanguageserver:You should then clearly see any fatal error...
fcojavierdomenech commentedon Jun 14, 2020
Nope haha, with this config it's working!
I don't know why otherwise it doesn't :/
Thanks a lot for your work
dantleech commentedon Jun 14, 2020
ah ... you're missing the
language-serverargument in your original config:so that would explain that (no need to run the TCP server).
If that works, it doesn't explain why the CoC extension didn't work though 🤔
dantleech commentedon Jun 14, 2020
(Where did you get the instruction for the
:CocConfigyou started with?)fcojavierdomenech commentedon Jun 14, 2020
I just tried your final settings and everything works :)
Regarding the
:CocConfigI just tried to replicate the ones of the README of nvim coc, I tried a few things before from here without success:dantleech commentedon Jun 14, 2020
hmm, ok. guess I need to add more debugging to
coc-phpactorand maybe also document the manual configuration.Glad it works - shame
coc-phpactordoesn't though 👀fcojavierdomenech commentedon Jun 14, 2020
Well, to be fair it was my first coc extension ever. But I agree with documenting it.
I dunno why coc-phpactor failed in my case, are there any more logs I can pass you?
Anyway, it's working :) Thanks!
dantleech commentedon Jun 14, 2020
Not that I'm aware - it's maybe a node JS issue of some kind...
dantleech commentedon Jun 20, 2020
ok - found the issue. it requires the
tslibdependency. I've published 1.0.3 of the package now, can you try again (:CocInstall coc-phpactor)dantleech commentedon Jun 20, 2020
Closing for now, reopen if it's still broken :)
fcojavierdomenech commentedon Jun 23, 2020
Just tested, it works, thanks :)