Repository navigation
Tolerate the case where phpactor returns an error - #13
Merged
Merged
Conversation
Collaborator
Author
|
cc @roxma from looking at the |
Collaborator
|
There's no standard way actually. We could filter-out annoying error, unless we never expect it to happen. This PR looks good to me. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phpactor throws exceptions in some cases (for example when classes cannot be located). In these cases it returns a JSON response with
{"error": "blah"}and does not have the['suggestions']key.This PR returns early if the
suggestionskey is not present.The response from Phpactor is logged in NCM2. Phpactor does not log errors encountered during normal command execution (RPC errors are logged however). PR in Phpactor to fix this here