Skip to content
This repository was archived by the owner on Mar 6, 2022. It is now read-only.

Include all the completion-related extensions in this package (and other stories) - #26

Merged
dantleech merged 19 commits into
masterfrom
add-extensions
Apr 4, 2020
Merged

dantleech merged 19 commits into
masterfrom
add-extensions

Conversation

@dantleech

@dantleech dantleech commented Apr 4, 2020 •

Copy link
Copy Markdown
Contributor

This PR adds all the completion related extensions to reduce maintainence overhead.

  • Integrates the abstract, worse, rpc and language server extensions (these packages will be deprecated / removed from github)
  • Upgrades the dev stack (PHPUnit 9, Phpstan 12 with Level 7)

This change will mean that improvements can be made much more quickly at the expense of potential package stability (but seeing as none of these packages were stable anyway, it's no loss).

Comment thread bin/completion
LoggingExtension::PARAM_ENABLED => true,
LoggingExtension::PARAM_LEVEL => 'debug',
LanguageServerExtension::PARAM_WELCOME_MESSAGE => 'Indexer test server',
LoggingExtension::PARAM_PATH=> 'php://stderr',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not indexer (also include this in phpcs fixer)

@dantleech
dantleech merged commit a94a737 into master Apr 4, 2020
@dantleech
dantleech deleted the add-extensions branch April 4, 2020 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant