Skip to content
This repository was archived by the owner on Mar 6, 2022. It is now read-only.

Register interesting offset finder - #1

Merged
dantleech merged 3 commits into
phpactor:masterfrom
camilledejoye:register-interesting-offset-finder
Oct 13, 2019
Merged

dantleech merged 3 commits into
phpactor:masterfrom
camilledejoye:register-interesting-offset-finder

Conversation

@camilledejoye

@camilledejoye camilledejoye commented Oct 13, 2019 •

Copy link
Copy Markdown
Contributor

Hi,

So this PR will register the new finder created in phpactor/code-transform#26
as a service.
Which will allow us to inject it to the ConextMenuHandler in https://github.com/phpactor/phpactor.

Just an note aside, I started a new job and they're using a git split strategy.
I don't know if you have already worked with something like that but the idea is to have all the code in the same place and split different parts in different repositories.
For instance the phpactor/phpactor project would contains a packages directory in which you would have a directory for each Phpactor's repositories (code-transform, worse-reflection, etc)
Allowing to work on every part of the project from only one repository.
Instead of jumping from one to another and playing with the composer.json to use a local repository and stuff like that.
I don't know how it behaves with forks but it might be worth looking into it in order to ease the workflow when working on features impacting more than one repository.

[EDIT] The CI will complain until phpactor/code-transform#26 is merged
You might have to restart manually once it's done

@dantleech

Copy link
Copy Markdown
Contributor

Just an note aside, I started a new job and they're using a git split strategy.
I don't know if you have already worked with something like that but the idea is to have all the code in the same place and split different parts in different repositories

Yes, this is the goal for the next release of Phpactor. I've already created https://github.com/phpactor/phpactor-packages as a POC and am hoping to automate the split (and manage the sub-packages) with https://github.com/dantleech/maestro (which is what I've been spending most of my spare time on for the past months :) )

@camilledejoye

Copy link
Copy Markdown
Contributor Author

Yes I saw it but a bit late :)
Is there a way to restart the CI ?

@dantleech

Copy link
Copy Markdown
Contributor

Restarted - hopefully packagist has updated.

Comment thread composer.json
"phpactor/container": "^1.0",
"phpactor/code-transform": "~0.1",
"phpactor/class-to-file-extension": "~0.1"
"phpactor/code-transform": "~0.2",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped this to 0.2

@dantleech
dantleech merged commit fdcf5bb into phpactor:master Oct 13, 2019
@camilledejoye
camilledejoye deleted the register-interesting-offset-finder branch October 13, 2019 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants