This repository was archived by the owner on Mar 6, 2022. It is now read-only.
Repository navigation
Register interesting offset finder - #1
Merged
dantleech merged 3 commits intoOct 13, 2019
Merged
Conversation
Contributor
Yes, this is the goal for the next release of Phpactor. I've already created https://github.com/phpactor/phpactor-packages as a POC and am hoping to automate the split (and manage the sub-packages) with https://github.com/dantleech/maestro (which is what I've been spending most of my spare time on for the past months :) ) |
Contributor
Author
|
Yes I saw it but a bit late :) |
Contributor
|
Restarted - hopefully packagist has updated. |
dantleech
reviewed
Oct 13, 2019
| "phpactor/container": "^1.0", | ||
| "phpactor/code-transform": "~0.1", | ||
| "phpactor/class-to-file-extension": "~0.1" | ||
| "phpactor/code-transform": "~0.2", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
So this PR will register the new finder created in phpactor/code-transform#26
as a service.
Which will allow us to inject it to the ConextMenuHandler in https://github.com/phpactor/phpactor.
Just an note aside, I started a new job and they're using a git split strategy.
I don't know if you have already worked with something like that but the idea is to have all the code in the same place and split different parts in different repositories.
For instance the phpactor/phpactor project would contains a
packagesdirectory in which you would have a directory for each Phpactor's repositories (code-transform, worse-reflection, etc)Allowing to work on every part of the project from only one repository.
Instead of jumping from one to another and playing with the composer.json to use a local repository and stuff like that.
I don't know how it behaves with forks but it might be worth looking into it in order to ease the workflow when working on features impacting more than one repository.
[EDIT] The CI will complain until phpactor/code-transform#26 is merged
You might have to restart manually once it's done