This repository was archived by the owner on Mar 6, 2022. It is now read-only.
Repository navigation
Change ExtractMethod return value to TextDocumentEdits - #48
Merged
Merged
Conversation
BladeMF
force-pushed
the
extract-method-text-edits
branch
from
May 11, 2021 06:13
2067bcf to
f219349
Compare
dantleech
suggested changes
May 11, 2021
| } | ||
|
|
||
| if ($stmt === false) { | ||
| dump($startNode->getStart(), $startNode->getEndPosition(), $offsetStart); |
Contributor
There was a problem hiding this comment.
shoudl this return false?
Contributor
There was a problem hiding this comment.
what should this do, should it return false
Contributor
Author
There was a problem hiding this comment.
No, I was trying to see when does this case occur. The point of the validation is to ensure that the start and end offsets are in the same code block:
{
...
<>
...
<>
...
}and there are multiple cases related to that depending on where the selection starts and ends. That case concerns the case "empty block", e.g.:
if {
<>
}The the start statement is the block itself. It's a valid statement to be extracted, so it doesn't need to return false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.