Skip to content
This repository was archived by the owner on Mar 6, 2022. It is now read-only.

Adds failing test for method call - #28

Merged
dantleech merged 2 commits into
masterfrom
interesting-offset-not-finding-method-call
Oct 14, 2019
Merged

dantleech merged 2 commits into
masterfrom
interesting-offset-not-finding-method-call

Conversation

@dantleech

Copy link
Copy Markdown
Contributor

No description provided.

@dantleech
dantleech force-pushed the interesting-offset-not-finding-method-call branch from cbd6e7e to 69ab60f Compare October 14, 2019 08:02
@camilledejoye

Copy link
Copy Markdown
Contributor

I tried to have a look at it.
It seems that the issue is that the node corresponds to $this->method() and not just only method so that $node->getStart() return the position of the $this variable...

Then I tried to work with getEndPosition() instead of getStart() but it broke 2 other tests...

@dantleech
dantleech force-pushed the interesting-offset-not-finding-method-call branch from ff3173a to 3c61923 Compare October 14, 2019 17:51
@dantleech
dantleech merged commit f50f156 into master Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants