Repository navigation
Add support for traits - #23
Conversation
Fixes phpactor/phpactor#726, but relies on phpactor/code-builder#9 to get the underlying trait() method added with all its supporting code.
|
Build is failing due to coding standards, you need to run:
(when in doubt |
|
Thanks for the hint. Running |
|
btw would also be good to add a regression test for this, should be enough just to add a single test case in |
|
Good news is the code styling bug was a simple blank line. Nice easy fix so I'll sort that when I add the Going to take a quick break to prepare dinner, but should hopefully have this ready fairly soon. Thanks for being so quick with the replies! Makes a massive difference ;) |
Also fixes blank line introduced a couple commits back to please Travis.
Considered adding an abstract method to ClassLikeBuilder in phpactor/code-builder, but this would break InterfaceBuilder and doesn't seem to make any difference to the outcome of phpstan's checks.
|
Test and resolver added, all green and Stan's happy too. Now to travis for the final verdict! |
|
Great, thanks! |
Fixes phpactor/phpactor#726, but relies on phpactor/code-builder#9 to
get the underlying trait() method added with all its supporting code.