Skip to content

Fix failed to open stream in deep whois#80

Open
Adlaran wants to merge 2 commits intophpWhois:4-stablefrom
Adlaran:hotfix_fixFailOpenStreamInDeepWhois
Open

Fix failed to open stream in deep whois#80
Adlaran wants to merge 2 commits intophpWhois:4-stablefrom
Adlaran:hotfix_fixFailOpenStreamInDeepWhois

Conversation

@Adlaran
Copy link
Copy Markdown

@Adlaran Adlaran commented Jul 14, 2017

Fopen in DeepWhois method fails when trying to open nonexistent file like whois.gtld.xxxx.php

@Adlaran Adlaran force-pushed the hotfix_fixFailOpenStreamInDeepWhois branch from 3fcc92f to bbca495 Compare July 14, 2017 03:00
@Adlaran Adlaran force-pushed the hotfix_fixFailOpenStreamInDeepWhois branch from bbca495 to 474672b Compare July 14, 2017 03:20
@NikoGrano
Copy link
Copy Markdown

Hi!

If you see this issue still relevant and could be fixed by this PR. Please submit it to https://github.com/niko9911/phpWhois.

I will make sure it will be checked and merged if necessary. Thank you for contributing.

@Adlaran
Copy link
Copy Markdown
Author

Adlaran commented Sep 12, 2019

@Niko9911
Hi

There were files for generic top level domains (gtld) in original phpWhois repository. You moved this files in another directory (old/src/gtld), so even if I apply my small fix, it will not work properly anyway.

You probably need to fix your paths and use file_exists() instead of this strange construction with fopen() fclose().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants