Fixes deprecated PHP 4 style constructors by renaming them to __construct()#62
Open
gdevlugt wants to merge 1 commit intophpWhois:4-stablefrom
Open
Fixes deprecated PHP 4 style constructors by renaming them to __construct()#62gdevlugt wants to merge 1 commit intophpWhois:4-stablefrom
gdevlugt wants to merge 1 commit intophpWhois:4-stablefrom
Conversation
|
Why isn't this changed pushed out to composer? If you're using PHP 7.x with phpwhois installed via composer, there is currently no fix for the deprecated constructors. Please get on the ball and push out a fix for this. |
|
Hi! If you see this issue still relevant and could be fixed by this PR. Please submit it to https://github.com/niko9911/phpWhois. I will make sure it will be checked and merged if necessary. Thank you for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using phpWhois 4-stable with PHP 7.0.8, PHP returns the following deprecation warnings because old PHP 4 style constructors are used.
The PR fixes this by renaming the mentioned deprecated constructors to
__construct.Since the minimum required PHP version for this phpWhois version is 5.3, and because PHP 5.3 supports constructors named
__construct, this won't break compatibility with older PHP versions.