Skip to content

[0.x] Test on PHP 7.3#87

Merged
jaapio merged 3 commits intophpDocumentor:0.7.xfrom
GrahamCampbell:patch-1
Dec 20, 2019
Merged

[0.x] Test on PHP 7.3#87
jaapio merged 3 commits intophpDocumentor:0.7.xfrom
GrahamCampbell:patch-1

Conversation

@GrahamCampbell
Copy link
Contributor

No description provided.

@GrahamCampbell GrahamCampbell changed the title Test on PHP 7.3 and 7.4 [0.x] Test on PHP 7.3 Dec 20, 2019
@GrahamCampbell
Copy link
Contributor Author

Looks like PHP 7.4 is not working on 0.x, but was fixed on 1.x. We should still test on PHP 7.3, though.

@GrahamCampbell
Copy link
Contributor Author

The test failures seem unrelated.

@jaapio
Copy link
Member

jaapio commented Dec 20, 2019

Yes they are, it is ok to merge this.

@jaapio jaapio merged commit e424cdf into phpDocumentor:0.7.x Dec 20, 2019
@jaapio
Copy link
Member

jaapio commented Dec 20, 2019

Thanks!

@GrahamCampbell GrahamCampbell deleted the patch-1 branch December 20, 2019 14:36
@GrahamCampbell
Copy link
Contributor Author

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants