Skip to content

Add all and any expected conditions #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add all and any expected conditions #777

wants to merge 12 commits into from

Conversation

@barbaris-in
Copy link

@barbaris-in barbaris-in commented Mar 22, 2020 •
edited
Loading

Along with a not condition would be great to have and and or conditions. I called them all and any respectively

williamdes
williamdes approved these changes Mar 22, 2020
View reviewed changes
Copy link
Collaborator

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me, could you add some tests for the 2 new functions ?

williamdes
williamdes reviewed Mar 22, 2020
View reviewed changes
williamdes
williamdes reviewed Mar 22, 2020
View reviewed changes
williamdes
williamdes suggested changes Mar 22, 2020
View reviewed changes
Copy link
Collaborator

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you the new tests 💯

@barbaris-in
Copy link
Author

barbaris-in commented Mar 22, 2020

Should I add some functional tests?

williamdes
williamdes reviewed Mar 22, 2020
View reviewed changes
williamdes
williamdes reviewed Mar 22, 2020
View reviewed changes
williamdes
williamdes reviewed Mar 22, 2020
View reviewed changes
@williamdes
Copy link
Collaborator

williamdes commented Mar 22, 2020

Should I add some functional tests?

@OndraM what do you recommend ?

@OndraM OndraM self-requested a review March 22, 2020 14:34
@OndraM OndraM changed the base branch from master to main June 23, 2020 10:03
@OndraM OndraM added the enhancement New feature label Oct 6, 2020
@williamdes williamdes requested review from OndraM and removed request for OndraM February 2, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OndraM OndraM Awaiting requested review from OndraM

1 more reviewer

@williamdes williamdes williamdes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barbaris-in @williamdes @OndraM