Skip to content

Fix sendKeys not accepting array as input#759

Merged
OndraM merged 1 commit intophp-webdriver:masterfrom
OndraM:fix/sendkeys-array-input
Feb 13, 2020
Merged

Fix sendKeys not accepting array as input#759
OndraM merged 1 commit intophp-webdriver:masterfrom
OndraM:fix/sendkeys-array-input

Conversation

@OndraM
Copy link
Collaborator

@OndraM OndraM commented Feb 11, 2020

Fixes #758

Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ondřej,

Just two things:

  1. minor grammatical fix
  2. double-encoding

Neither are major issues, but I think that we should fix the double-encoding here before it comes back and bites us in the future.

@OndraM OndraM force-pushed the fix/sendkeys-array-input branch from facd7b6 to ad43cc1 Compare February 12, 2020 11:20
@OndraM OndraM merged commit 7729633 into php-webdriver:master Feb 13, 2020
@lordjancso
Copy link

@OndraM Thank you for the fix! Will you release this patch soon?

@OndraM OndraM deleted the fix/sendkeys-array-input branch February 13, 2020 15:24
@OndraM
Copy link
Collaborator Author

OndraM commented Feb 13, 2020

@lordjancso I'm also currently taking care of #757 which was introduced in 1.8.0 - so I'd like to release the fix for both of the issues at the same time.

@lordjancso
Copy link

@OndraM Okay, thank you for the info.
Do you have any ETA of the release or should I lock to 1.7.1? My tests are completely broken with 1.8.0.

@OndraM
Copy link
Collaborator Author

OndraM commented Feb 13, 2020

Sorry, we generally do not provide any ETAs. But if #757 builds goes well (there is already a pull request with the fix #764), is could be soon.

However you can already add dependency to your composer.json require section:

"php-webdriver/webdriver": "dev-master as 1.8.1"

and start using it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sendKeys on RemoteWebElement no longer accepts an array

3 participants