Disable W3C protocol in Chrome 75+#640
Merged
OndraM merged 1 commit intophp-webdriver:communityfrom Jun 9, 2019
Merged
Conversation
OndraM
changed the title
OndraM
changed the title
This was referenced Jun 8, 2019
This was referenced Jun 10, 2019
This was referenced Nov 10, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromedriver 75 released together with Chrome 75 on 4th June 2019 uses W3C WebDriver protocol by default.
But php-webdriver does not (see #469) support this protocol yet, so this hotfix disables the W3C WebDriver protocol and re-enables the old one JsonWire aka OSS.
Unfortunately, this change in Chromedriver 75 accidentally broke the old JsonWire protocol, so just disabling the new protocol is not enough :-/. See Chromedriver bug 2943. The bug causes Chromedriver to require at least some data in POST body request (what should not be required in JsonWire protocol). So as a workaround for the Chromedriver bug, we are adding some dummy data in the body (as suggested here), until Chrome team fixes the bug.