Skip to content

Mozilla firefox geckodriver fix. #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zyrukas wants to merge 2 commits into from
Closed

Mozilla firefox geckodriver fix. #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0357dc2
Mozilla firefox geckodriver fix.
May 25, 2018
dc29be2
php 5.6 fix
May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ This project versioning adheres to [Semantic Versioning](http://semver.org/).

---

### Fixed
- Mozilla firefox geckodriver fix. ([PHPUnit\Framework\Exception] Undefined index: ELEMENT)

## 1.6.0 - 2018-05-16
### Added
- Connection and request timeouts could be specified also when creating RemoteWebDriver from existing session ID.
Expand Down
8 changes: 6 additions & 2 deletions lib/Remote/RemoteWebDriver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@ public function findElement(WebDriverBy $by)
$params
);

return $this->newElement($raw_element['ELEMENT']);
return $this->newElement(
isset($raw_element['ELEMENT']) ? $raw_element['ELEMENT'] : $raw_element[\key($raw_element)]
Copy link

@ghost ghost Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, you can create a separate function. In order not to violate DRY

private function _getElement($raw_element) {
    return isset($raw_element['ELEMENT']) ? 
        $raw_element['ELEMENT'] : $raw_element[\key($raw_element)];
}

);
}

/**
Expand All @@ -207,7 +209,9 @@ public function findElements(WebDriverBy $by)

$elements = [];
foreach ($raw_elements as $raw_element) {
$elements[] = $this->newElement($raw_element['ELEMENT']);
$elements[] = $this->newElement(
Copy link

@ghost ghost Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$elements[] = $this->newElement($this->_getElement($raw_element));

isset($raw_element['ELEMENT']) ? $raw_element['ELEMENT'] : $raw_element[\key($raw_element)]
);
}

return $elements;
Expand Down