Skip to content

Override the content type and encoding in the XML to work similar to SoapClient - #181

Open
jacques wants to merge 2 commits into
php-vcr:masterfrom
jacques:master
Open

Override the content type and encoding in the XML to work similar to SoapClient#181
jacques wants to merge 2 commits into
php-vcr:masterfrom
jacques:master

Conversation

@jacques

@jacques jacques commented Dec 3, 2016

Copy link
Copy Markdown

Context

PHP-VCR ignores the encoding required from the WSDL which one needs to manually pass in.

What has been done

  • If encoding is in options in the SoapHook set the content type header for the encoding
  • In the XML if the encoding is in the options replace UTF-8 with the given encoding.

How to test

Todo

  • [ ]

Notes

@renatomefi

Copy link
Copy Markdown
Member

@jacques thanks for you PR!

Can you write some tests where the XML isn't utf-8?

Thank you agian!

@higidi higidi added Bug Something isn't working Help wanted Need volunteers to get this issue/pr ready labels Jun 9, 2026
@higidi higidi self-assigned this Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Help wanted Need volunteers to get this issue/pr ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants