Use new static for submenu#68
Merged
AydinHassan merged 1 commit intophp-school:masterfrom Dec 11, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
============================================
+ Coverage 88.76% 88.79% +0.03%
- Complexity 239 241 +2
============================================
Files 18 18
Lines 730 732 +2
============================================
+ Hits 648 650 +2
Misses 82 82
Continue to review full report at Codecov.
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On add submenu use "new static" not "new self"
This way a subclass of CliMenuBuilder will add sub menus of the same subclass type and not the parent class type.
This makes it easier to meaningfully extend.