Accept any callable as argument for addSubMenu and addSplitItem in CliMenuBuilder#275
Merged
AydinHassan merged 2 commits intophp-school:masterfrom Aug 27, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
=========================================
Coverage 93.46% 93.46%
Complexity 656 656
=========================================
Files 38 38
Lines 2021 2021
=========================================
Hits 1889 1889
Misses 132 132
☔ View full report in Codecov by Sentry. |
Member
|
Nice thanks, do you think you could also update |
Contributor
Author
Just did it. |
simonorono
changed the title
AydinHassan
approved these changes
Aug 27, 2023
Member
|
Thanks @simonorono ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on a personal project I was structuring all actions to be callable objects (using the
__invokemethod) and stumbled upon theaddSubMenumethod not accepting them as a callback. This PR modifies the argument type so it accepts any callable as defined here