feat(password): Make password having custom length#235
feat(password): Make password having custom length#235AydinHassan merged 1 commit intophp-school:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
============================================
+ Coverage 92.86% 92.87% +<.01%
- Complexity 622 623 +1
============================================
Files 37 37
Lines 1864 1866 +2
============================================
+ Hits 1731 1733 +2
Misses 133 133
Continue to review full report at Codecov.
|
|
Looks good to me! Only one thing, adding the method |
Hey :) Are you sure about that? because there are only 3 classes which implement the
There are all located in namespace Also, even if people have extended these classes, the |
|
hey @samijnih if any body is implementing the interface to create their own inputs they might not have the |
You're right, I'm gonna update it |
- fix phpdoc type error in password unit test - add new internal property about password length with default value int "16" - replace hard coded password length comparison with that internal property - add a new setter for a custom password length - add missing ext-mbstring to composer.json - add setValidator to Input interface - add tests in PasswordTest
samijnih
force-pushed
the
feat/set-password-input-length
branch
from
aee9d12 to
6f30f2d
Compare
|
thank you @samijnih ! |
|
You're welcome! |
3 participants
Why
Hello :)
I'm currently using your api to make a php cli menu for my app.
I've been facing a problem when I wanted to make a user registration area.
So the aim of my pull request is to allow developers like me to call a setter in order to give another length. Of course, I made it backward-compatible so the previous value is a default value if the new method is not called.
Description