Selectable item styles#214
Merged
AydinHassan merged 5 commits intophp-school:masterfrom Dec 20, 2019
jtreminio:feature/selectable-style
Merged
Selectable item styles#214AydinHassan merged 5 commits intophp-school:masterfrom jtreminio:feature/selectable-style
AydinHassan merged 5 commits intophp-school:masterfrom
jtreminio:feature/selectable-style
Conversation
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
============================================
- Coverage 93.52% 93.29% -0.23%
- Complexity 558 589 +31
============================================
Files 30 31 +1
Lines 1667 1760 +93
============================================
+ Hits 1559 1642 +83
- Misses 108 118 +10
Continue to review full report at Codecov.
|
AydinHassan
requested changes
Dec 20, 2019
| @@ -396,22 +397,25 @@ public function setMargin(int $margin) : self | |||
| public function setUnselectedMarker(string $marker) : self | |||
Member
There was a problem hiding this comment.
Let's just drop these methods. It's just a little BC break.
Contributor
Author
There was a problem hiding this comment.
Still needed for MenuMenuItem. I can completely drop in next PR for that item's style.
Member
|
Everything else looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.