Adds RadioItem and ToggableTrait#194
Merged
AydinHassan merged 6 commits intophp-school:masterfrom Dec 17, 2019
jtreminio:feature/radio-item
Merged
Adds RadioItem and ToggableTrait#194AydinHassan merged 6 commits intophp-school:masterfrom jtreminio:feature/radio-item
AydinHassan merged 6 commits intophp-school:masterfrom
jtreminio:feature/radio-item
Conversation
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
============================================
- Coverage 93.2% 93.08% -0.12%
- Complexity 491 516 +25
============================================
Files 27 29 +2
Lines 1486 1562 +76
============================================
+ Hits 1385 1454 +69
- Misses 101 108 +7
Continue to review full report at Codecov.
|
AydinHassan
approved these changes
Dec 17, 2019
Member
AydinHassan
left a comment
AydinHassan
left a comment
There was a problem hiding this comment.
few redundant docs, i'll remove them. Thanks a lot, looks great!
| /** | ||
| * Gets checked state | ||
| * | ||
| * @return bool |
| /** | ||
| * The output text for the item | ||
| * | ||
| * @param MenuStyle $style |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing fancy screenshot.
Also adds
SpliItemTest::testCheckableItem()