Auto-toggle CheckableItem#193
Merged
AydinHassan merged 2 commits intophp-school:masterfrom Dec 17, 2019
jtreminio:feature/checkable-getSelectAction
Merged
Auto-toggle CheckableItem#193AydinHassan merged 2 commits intophp-school:masterfrom jtreminio:feature/checkable-getSelectAction
AydinHassan merged 2 commits intophp-school:masterfrom
jtreminio:feature/checkable-getSelectAction
Conversation
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
============================================
+ Coverage 93.05% 93.06% +0.01%
Complexity 491 491
============================================
Files 27 27
Lines 1483 1486 +3
============================================
+ Hits 1380 1383 +3
Misses 103 103
Continue to review full report at Codecov.
|
Member
|
Nice, was going to suggest this myself! |
AydinHassan
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per this comment it makes sense for a CheckboxItem to auto-toggle itself (either on or off) vs forcing developer to implement this themselves.
CheckableItem::getSelectAction()returns acallablewithin acallable. The outercallabledoes the auto-toggling, the innercallableis the user-defined code.The
CheckableItemTest::testGetSelectAction()reflects this stacking.