Initial checkable item support#186
Initial checkable item support#186AydinHassan merged 6 commits intophp-school:masterfrom jtreminio:feature/toggleable-item
Conversation
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
===========================================
- Coverage 93.29% 93.19% -0.1%
- Complexity 460 486 +26
===========================================
Files 26 27 +1
Lines 1402 1470 +68
===========================================
+ Hits 1308 1370 +62
- Misses 94 100 +6
Continue to review full report at Codecov.
|
AydinHassan
left a comment
AydinHassan
left a comment
There was a problem hiding this comment.
I think we should drop item extra support from this item, I can't imagine it being very useful in this circumstance. What do you think?
Overall it looks great. I've left a few other comments to address, mostly regarding renaming a few things. But I'd say go ahead and add tests :)
/cc @mikeymike
Would prefer this be a separate PR. |
|
Pending unit tests. |
AydinHassan
left a comment
AydinHassan
left a comment
There was a problem hiding this comment.
Everything looks great now apart from one comment.
jtreminio
changed the title
|
LGTM! Thanks a lot @jtreminio |
3 participants
edit: Ready for merging.
Related to #185