Skip to content

adds ability to set custom validator on Text and Number inputs#177

Merged
AydinHassan merged 1 commit intophp-school:masterfrom
vesper8:master
Apr 5, 2019
Merged

adds ability to set custom validator on Text and Number inputs#177
AydinHassan merged 1 commit intophp-school:masterfrom
vesper8:master

Conversation

@vesper8
Copy link
Contributor

@vesper8 vesper8 commented Apr 4, 2019

nothing special here, just added the same functionality currently available on the Password field to the Number and Text fields

@codecov-io
Copy link

codecov-io commented Apr 4, 2019

Codecov Report

Merging #177 into master will decrease coverage by 1.01%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #177      +/-   ##
============================================
- Coverage     97.26%   96.24%   -1.02%     
- Complexity      423      429       +6     
============================================
  Files            25       25              
  Lines          1317     1333      +16     
============================================
+ Hits           1281     1283       +2     
- Misses           36       50      +14
Impacted Files Coverage Δ Complexity Δ
src/Input/Text.php 79.41% <12.5%> (-20.59%) 14 <1> (+3)
src/Input/Number.php 81.57% <12.5%> (-18.43%) 16 <1> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83fbce5...96b37dc. Read the comment docs.

@AydinHassan AydinHassan merged commit 40f0c13 into php-school:master Apr 5, 2019
@AydinHassan
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants