Split padding in top/bottom and left/right#121
Merged
AydinHassan merged 7 commits intophp-school:masterfrom May 10, 2018
Merged
Split padding in top/bottom and left/right#121AydinHassan merged 7 commits intophp-school:masterfrom
AydinHassan merged 7 commits intophp-school:masterfrom
Conversation
Moved arg checks from Builder to MenuStyle Fixed some spaces-only lines
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
============================================
+ Coverage 96.87% 96.95% +0.07%
- Complexity 342 356 +14
============================================
Files 23 23
Lines 1057 1117 +60
============================================
+ Hits 1024 1083 +59
- Misses 33 34 +1
Continue to review full report at Codecov.
|
AydinHassan
approved these changes
May 10, 2018
Member
|
Looks great - thanks! I'll take care of the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and breaking tests as always :)