Conversation
Contributor
|
Travis is broken, too. No more status on PRs. But its erroring for different reason now: https://travis-ci.org/github/php-pm/php-pm-httpkernel |
Contributor
|
Do you want to merge my pr, too, into yours? |
Contributor
Author
|
so on your PR there are 2 different commits, no? The Drupal bootstrap also usess the HttpKernel, that's why it's probably being required too |
Contributor
|
I removed it as we‘re not testing it anywhere, but up to you |
Contributor
Author
|
@andig I put your composer commit in here, tests are green again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andig this should fix your PR