[rfr] Get console vnc/serial/rdp/spice methods#88
Merged
jamiehannaford merged 3 commits intophp-opencloud:masterfrom Aug 31, 2016
Merged
[rfr] Get console vnc/serial/rdp/spice methods#88jamiehannaford merged 3 commits intophp-opencloud:masterfrom
jamiehannaford merged 3 commits intophp-opencloud:masterfrom
Conversation
haphan
changed the title
| * Defaults to novnc. | ||
| * | ||
| * @return mixed | ||
| */ |
Contributor
There was a problem hiding this comment.
Why is $type an arg here? Surely it'll always be novnc for this operation? I like removing all unnecessary expectations for users.
Collaborator
Author
There was a problem hiding this comment.
@jamiehannaford Type is an arg here so that user can pass custom type if needed.
Type can be either novnc or xvpvnc. novnc seems to be the only type get documented according to doc so I put it as the default parameter.
Contributor
|
Looks great, just a few really minor issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jamiehannaford Please review