Add server console output#145
Conversation
| * | ||
| * @param int $length The number of lines, by default all lines will be returned. | ||
| * @return string | ||
| */ |
There was a problem hiding this comment.
Could use a return typehint
| * | ||
| * @param int $length The number of lines, by default all lines will be returned. | ||
| * @return string | ||
| */ |
There was a problem hiding this comment.
What is the logic behind default valuelength = -1?
There was a problem hiding this comment.
When given a length of -1, the API will return all lines. Since the default (when no length is specified) in the OpenStack docs is returning all lines as well, I thought it was reasonable to make this the default here.
There was a problem hiding this comment.
When given a length of -1, the API will return all lines
This is an assumption thus subject to change in the future; I think we better follow official docs that length shall not be included in the request if we want API to return all lines.
There was a problem hiding this comment.
Good point, will make that change soon 😄.
|
@casperboone Only have one small comment for you. Otherwise all looks good. |
casperboone
force-pushed
the
console_output
branch
from
5730866 to
a37eb93
Compare
|
@haphan Updated the implementation, could you please have another look? 😄 |
|
@casperboone Can you rebase with master branch? |
casperboone
force-pushed
the
console_output
branch
from
a37eb93 to
f85eb66
Compare
|
@haphan Done! :) |
3 participants
This PR adds the ability to get the console output of a server (see OpenStack docs ).