Updates the dispatch() event parameter order for Symfony 4.3+#18
Closed
boroth wants to merge 1 commit intophp-enqueue:masterfrom
Closed
Updates the dispatch() event parameter order for Symfony 4.3+#18boroth wants to merge 1 commit intophp-enqueue:masterfrom
boroth wants to merge 1 commit intophp-enqueue:masterfrom
Conversation
Member
|
@boroth Could you please remove symfony 3 from composer ? |
Member
|
dupl #32 |
Author
|
Sorry, didn't see this until now. Thanks for taking care of the composer dependency! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something that goes along with this issue and pull request for FOSElasticaBundle. In Symfony 4.3, the order of the parameters changed for the
dispatch()event.I'm not good at all with PHPUnit, and I don't understand the tests they're running on FOSElasticaBundle, so the tests are failing there and they haven't been able to merge it yet. I'll have to do more work to get the tests updated properly before they'll merge I'd guess.