Skip to content

[Symfony] Try to get env parameter from container before throwing an exception - #587

Closed
Steveb-p wants to merge 1 commit into
php-enqueue:0.8from
Steveb-p:0.8
Closed

Steveb-p wants to merge 1 commit into
php-enqueue:0.8from
Steveb-p:0.8

Conversation

@Steveb-p

Copy link
Copy Markdown
Contributor

In regard to an issue raised on gitter.

image

@makasim

makasim commented Oct 26, 2018

Copy link
Copy Markdown
Member

The issue was properly fixed in 0.9 version. Unfortunately, it is not possible to fix it in 0.8 version.
There is another attempt to do it #533

if (false === $realDsn = getenv($matches[1])) {
throw new \LogicException(sprintf('The env "%s" var is not defined', $matches[1]));
try {
$realDsn = $container->getParameter($matches[1]);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be $dsn instead of $matches[1]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Steveb-p ping ^^

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look at it tonight :)

@makasim

makasim commented Nov 15, 2018

Copy link
Copy Markdown
Member

@Steveb-p is there any news?

@makasim

makasim commented Nov 16, 2018

Copy link
Copy Markdown
Member

The issue is properly fixed in 0.9 version which is soon to be released.

@makasim makasim closed this Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants