feat: recover Windows test runs#89
Merged
carlos-granados merged 1 commit intoMay 18, 2026
Merged
Conversation
carlos-granados
force-pushed
the
feat/recover-windows-tests
branch
19 times, most recently
from
6c8aea4 to
06f36c2
Compare
carlos-granados
force-pushed
the
feat/recover-windows-tests
branch
from
06f36c2 to
1b2cb57
Compare
carlos-granados
commented
May 17, 2026
| [%d] [Step Debug] WARN: Creating socket for 'doesnotexist3:9003', getaddrinfo: %d. | ||
| [%d] [Step Debug] WARN: Could not connect to client host discovered through HTTP headers, connecting to configured address/port: doesnotexist2:9003. | ||
| [%d] [Step Debug] WARN: Creating socket for 'doesnotexist2:9003', getaddrinfo: 11001. | ||
| [%d] [Step Debug] DEBUG: Adding header 'Content-type: %s'. |
Collaborator
Author
There was a problem hiding this comment.
This tests needs updating the same way as all the other remote-log tests with the extra debugging output for headers. I had not updated it previously because it only runs on Windows, so I had not noticed that it was failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovers testing on Windows which had been removed on a previous step.
Main problem was that we had defined the extension as having the name
debugger, notphp-debugger. This meant that some checks for the COMPILE_DL_PHP_DEBUGGER flag were not working as it was actually being set as COMPILE_DL_DEBUGGER. Updating config.m4 to use this correct name fixes the problem and all tests on Windows are now passing 👍Notice that now the DLL is named php_php_debugger.dll. This is correct as Windows DLLs are all named
php_name_of_the extension.dllso the duplicatephp_bit matches the standard