fix: restore xdebug_execute_ex#57
Merged
carlos-granados merged 1 commit intoMay 3, 2026
Merged
Conversation
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
fix/restore-execute-ex
branch
from
32304e6 to
aebe0e7
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
fix/restore-execute-ex
branch
from
a366c95 to
d01ed38
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
fix/restore-execute-ex
branch
from
d01ed38 to
1019dd2
Compare
pronskiy
added
performance-check
carlos-granados
force-pushed
the
fix/restore-execute-ex
branch
from
1019dd2 to
78c51d2
Compare
carlos-granados
added
performance-check
carlos-granados
force-pushed
the
fix/restore-execute-ex
branch
from
78c51d2 to
1e2f141
Compare
Member
|
Makes sense, altho I'm wondering if can drop eval support and get some benefits? |
Collaborator
Author
Given that this is not affecting performance when we are not connected, which is our main goal, I would say that we should go ahead with this. Then I can take a deeper look when I work on more optimizations for the case when you are connected to the debugging client |
Collaborator
Author
pronskiy
approved these changes
May 3, 2026
Member
|
Okay, let's goo 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the optimization of the debugger we had removed the xdebug_execute_ex function which is called for each php function. Unfortunately, this cannot be removed because this is needed for "include", "require" and "eval" as these are not covered by the observer api. This PR adds this function back. This will only be activated if the debugger is connected, so that the small performance penalty is not felt if it is not connected.
See this performance run which confirms that performance is not affected if the debugger does not connect:
https://github.com/php-debugger/php-debugger/actions/runs/24549308291
This fixes one of the remaining XFAIL tests, which was an actual bug