Unify design of all release pages#1916
Open
theodorejb wants to merge 6 commits into
Open
Conversation
theodorejb
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
theodorejb
changed the title
This improves readability (particularly on smaller screens), since code blocks with overflow can be easily scrolled horizontally to read longer lines, rather than trying to visually parse code with line breaks in unintended places (which can even appear as invalid syntax when a line break is in the middle of a token).
This is possible on the previous release pages, but for some reason wasn't implemented for PHP 8.5.
theodorejb
force-pushed
the
unify-release-page-design
branch
from
dc4f125 to
eb70642
Compare
Enables dark mode, syntax highlighting of variables, and unified design for all release pages. Release pages prior to 8.5 still lack the Key Features section. Also fixed inconsistent i18n language spelling in the PHP 8.4 release page dropdown. No other content has been changed.
Also fix invalid syntax for the .hero-content background-image.
Also removed duplicate feature title translation strings.
theodorejb
force-pushed
the
unify-release-page-design
branch
from
eb70642 to
bb51799
Compare
Contributor
Author
|
Example screenshot of the PHP 8.0 release page in dark mode: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the design of the PHP 8.0-8.4 release pages to match PHP 8.5, with dark mode support, syntax highlighting of variables in code blocks, buttons to copy code blocks, and other design improvements. Release pages prior to 8.5 still lack the Key Features section.
Also moved to functions for rendering the hero section, feature comparisons, and footer, to avoid duplicating huge amounts of markup and simplify maintaining consistent styling.
No content has been changed, except for fixing inconsistent i18n language spelling in the PHP 8.4 release page dropdown, and correctly styling code in PHP 8.5 feature headings (as was already done on previous release pages).
Builds on top of #1914, so that should be merged first.