Avoid wrapping PHP 8.5 release code blocks#1914
Open
theodorejb wants to merge 2 commits into
Open
Conversation
theodorejb
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
Member
Contributor
Author
|
I also added a commit to allow linking to the "Additional features and improvements" and "Deprecations and backward compatibility breaks" headings. This works on the other release pages, but for some reason wasn't implemented on the PHP 8.5 release page. |
theodorejb
force-pushed
the
improve-code-blocks
branch
from
d2dc52c to
b61c2d4
Compare
This improves readability (particularly on smaller screens), since code blocks with overflow can be easily scrolled horizontally to read longer lines, rather than trying to visually parse code with line breaks in unintended places (which can even appear as invalid syntax when a line break is in the middle of a token).
This is possible on the previous release pages, but for some reason wasn't implemented for PHP 8.5.
theodorejb
force-pushed
the
improve-code-blocks
branch
from
b61c2d4 to
0d9b533
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves readability (particularly on smaller screens), since code blocks with overflow can be easily scrolled horizontally to read longer lines, rather than trying to visually parse syntax with line breaks in unintended places (which can even appear invalid when a line break is in the middle of a token).
Before:
After:
