Skip to content

Add support for Disjoint Normal Form (DNF) types #8725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Girgias merged 13 commits into from
Jul 8, 2022
Merged

Add support for Disjoint Normal Form (DNF) types #8725

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5e5324c
Disjunctive normal form types
Girgias Aug 11, 2021
4f22afa
Check for redundant types
Girgias Dec 20, 2021
1cea4db
Properly register unresolved classes
Girgias Jun 7, 2022
a942f50
TODO Comment about improving error message
Girgias Jun 7, 2022
72652e9
Add an assertion and eliminate dead code
Girgias Jun 9, 2022
4da371b
XFAIL test for the time being
Girgias Jun 9, 2022
59659cc
Improve wording of redudant intersection types in unions
Girgias Jun 10, 2022
a017ac8
Add some assertions
Girgias Jun 10, 2022
aae8472
Fix OpCache not recursively storing in persistent memory sub intersec…
Girgias Jun 11, 2022
f963d06
Improve union type parsing
Girgias Jun 14, 2022
5a292c6
Adjust elide_return_type DFA pass function
Girgias Jun 14, 2022
d399f3e
Adjust Zend Accelerator
Girgias Jun 14, 2022
521f3f1
Add assertion + TODO for test for gen_stub support of DNF types
Girgias Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Properly register unresolved classes
  • Loading branch information
@Girgias
Girgias committed Jun 14, 2022
commit 1cea4db1640fd297793c8e55ccac47c4e70f4593
18 changes: 18 additions & 0 deletions Zend/tests/type_declarations/dnf_types/variance/valid9.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
--TEST--
Covariant replacement of iterable type with unregistered intersection type in DNF type
--FILE--
<?php

class Test {
function method1(): iterable|string {}
function method2(): iterable|int {}
}
class Test2 extends Test {
function method1(): (X&Traversable)|string {}
function method2(): int|(X&MyIterator) {}
}

?>
===DONE===
--EXPECTF--
Fatal error: Could not check compatibility between Test2::method2(): (X&MyIterator)|int and Test::method2(): Traversable|array|int, because class X is not available in %s
4 changes: 4 additions & 0 deletions Zend/zend_inheritance.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,10 @@ static zend_string *get_class_from_type(zend_class_entry *scope, zend_type singl
static void register_unresolved_classes(zend_class_entry *scope, zend_type type) {
zend_type *single_type;
ZEND_TYPE_FOREACH(type, single_type) {
if (ZEND_TYPE_HAS_LIST(*single_type)) {
register_unresolved_classes(scope, *single_type);
continue;
}
if (ZEND_TYPE_HAS_NAME(*single_type)) {
zend_string *class_name = resolve_class_name(scope, ZEND_TYPE_NAME(*single_type));
lookup_class_ex(scope, class_name, /* register_unresolved */ true);
Expand Down