ZPP Failure on Overflow #835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zend/zend_API.c
Outdated
Contributor
Author
There was a problem hiding this comment.
bwoebi pointed out that I should check for (double)(ZEND_LONG_MAX + 1) on 32-bit as (double)(ZEND_LONG_MAX + 0.5) wouldn't truncate. I should probably #if this.
Contributor
Author
There was a problem hiding this comment.
Since we do overflow checks in a bunch of places, maybe we should have a macro? ZEND_DOUBLE_FITS_LONG(double)?
hikari-no-yume
force-pushed
the
zppFailOnOverflow
branch
from
44f3e15 to
d5afeef
Compare
Contributor
Author
|
The RFC was accepted, so I'll probably merge this in sometime soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP patch for this RFC: https://wiki.php.net/rfc/zpp_fail_on_overflow