Skip to content

[RFC] Support optional comma in closure use list #5793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TysonAndre wants to merge 1 commit into from
Closed

[RFC] Support optional comma in closure use list #5793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Support optional comma in closure use list 
RFC: https://wiki.php.net/rfc/trailing_comma_in_closure_use_list
Discussion: https://externals.io/message/110715
  • Loading branch information
@TysonAndre
TysonAndre committed Jul 1, 2020
commit cebbac923c1c88a9f52ae34d97506d55a97f10aa
17 changes: 17 additions & 0 deletions Zend/tests/closure_use_trailing_comma.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
--TEST--
Closure use list can have trailing commas
--FILE--
<?php

$b = 'test';
$fn = function () use (
$b,
&$a,
) {
$a = $b;
};
$fn();
echo "$a\n";
?>
--EXPECT--
test
2 changes: 1 addition & 1 deletion Zend/zend_language_parser.y
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,7 @@ returns_ref:

lexical_vars:
%empty { $$ = NULL; }
| T_USE '(' lexical_var_list ')' { $$ = $3; }
| T_USE '(' lexical_var_list possible_comma ')' { $$ = $3; }
;

lexical_var_list:
Expand Down