Skip to content

Make float to string conversions locale-independent #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kocsismate wants to merge 4 commits into from
+175 −40
Closed

Make float to string conversions locale-independent #5224

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
483636b
Make float to string casts locale-independent
kocsismate Feb 29, 2020
1209669
Finalize implementation
kocsismate May 6, 2020
b571762
Add UPGRADING note
kocsismate May 7, 2020
0b5adb0
Address code review comments
kocsismate May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add UPGRADING note
  • Loading branch information
@kocsismate
kocsismate committed May 7, 2020
commit b57176282b8ead6bc80fe4818d8a6a1d72b33e0c
2 changes: 2 additions & 0 deletions UPGRADING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ PHP 8.0 UPGRADE NOTES
array, resource or non-overloaded object. The only exception to this is the
array + array merge operation, which remains supported.
RFC: https://wiki.php.net/rfc/arithmetic_operator_type_checks
. Float to string casting will now always behave locale-independently.
RFC: https://wiki.php.net/rfc/locale_independent_float_to_string

- COM:
. Removed the ability to import case-insensitive constants from type
Expand Down