Skip to content

Saner string to number comparison #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikic wants to merge 3 commits into from
Closed

Saner string to number comparison #3886

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6524a72
Improved integer/float to string comparison semantics
nikic Feb 21, 2019
3038770
Add dedicated test
nikic Jul 2, 2020
e5c5d15
Fix test
nikic Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add dedicated test
  • Loading branch information
@nikic
nikic committed Jul 22, 2020
commit 3038770d107ed7bd07143c55bb8889b76b9f7b45
92 changes: 92 additions & 0 deletions Zend/tests/string_to_number_comparison.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
--TEST--
String to number comparison
--FILE--
<?php

// This tests the examples from the RFC.

function format($val) {
if (is_float($val)) {
if (is_nan($val)) return "NAN";
if ($val == INF) return "INF";
if ($val == -INF) return "-INF";
}
return json_encode($val);
}

function compare_eq($val1, $val2) {
echo format($val1), " == ", format($val2), ": ", format($val1 == $val2), "\n";
}

function compare_3way($val1, $val2) {
echo format($val1), " <=> ", format($val2), ": ", format($val1 <=> $val2), "\n";
}

compare_eq(42, "000042");
compare_eq(42, "42.0");
compare_eq(42.0, "+42.0E0");
compare_eq(0, "0e214987142012");
echo "\n";

compare_eq("42", "000042");
compare_eq("42", "42.0");
compare_eq("42.0", "+42.0E0");
compare_eq("0", "0e214987142012");
echo "\n";

compare_eq(42, " 42");
compare_eq(42, "42 ");
compare_eq(42, "42abc");
compare_eq(42, "abc42");
compare_eq( 0, "abc42");
echo "\n";

compare_eq(INF, "INF");
compare_eq(-INF, "-INF");
compare_eq(NAN, "NAN");
compare_eq(INF, "1e1000");
compare_eq(-INF, "-1e1000");
echo "\n";

$float = 1.75;

echo "precision=14:\n";
ini_set('precision', 14);
compare_3way($float, "1.75abc");
compare_3way((string) $float, "1.75abc");

echo "precision=0:\n";
ini_set('precision', 0);
compare_3way($float, "1.75abc");
compare_3way((string) $float, "1.75abc");

?>
--EXPECT--
42 == "000042": true
42 == "42.0": true
42 == "+42.0E0": true
0 == "0e214987142012": true

"42" == "000042": true
"42" == "42.0": true
"42.0" == "+42.0E0": true
"0" == "0e214987142012": true

42 == " 42": true
42 == "42 ": false
42 == "42abc": false
42 == "abc42": false
0 == "abc42": false

INF == "INF": true
-INF == "-INF": true
NAN == "NAN": false
INF == "1e1000": true
-INF == "-1e1000": true

precision=14:
1.75 <=> "1.75abc": -1
"1.75" <=> "1.75abc": -1
precision=0:
1.75 <=> "1.75abc": 1
"2" <=> "1.75abc": 1