[RFC] Make compact function reports undefined passed variables#3240
Closed
carusogabriel wants to merge 1 commit intophp:masterfrom
carusogabriel:warning-unknow-compact-variable
Closed
[RFC] Make compact function reports undefined passed variables#3240carusogabriel wants to merge 1 commit intophp:masterfrom carusogabriel:warning-unknow-compact-variable
carusogabriel wants to merge 1 commit intophp:masterfrom
carusogabriel:warning-unknow-compact-variable
Conversation
carusogabriel
commented
May 12, 2018
| --EXPECTF-- | ||
| Warning: compact(): Undefined variable: this in %s on line %d | ||
| array(1) { | ||
| ["this"]=> |
Contributor
Author
There was a problem hiding this comment.
Are these this warnings right?
Contributor
There was a problem hiding this comment.
It seems to be related to it only dealing with this a couple lines below in https://github.com/php/php-src/pull/3240/files#diff-497f073aa1ab88afcb8b248fc25d2a12R2595
carusogabriel
changed the title
Contributor
|
I see there is a special branch for '$this' but do we have a test covering it? Anyway, a minor detail, voted yes! |
Member
|
@marcioAlmada Yes, see #3240 (comment) :) |
Contributor
Author
|
Should be RTM as the RFC was Accepted 😄 |
|
Comment on behalf of cmb at php.net: Thanks. Applied via fc775f6. |
Contributor
|
@LC43 It is possible to declare variables with such malformed names: https://3v4l.org/M9mAJ |
|
oops, thanks for the correction, @Majkl578! I'll remove my initial comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://externals.io/message/102012
RFC: https://wiki.php.net/rfc/compact