Repository navigation
ext/standard: fix use-after-free and resource reuse from write_seek_mode - #25401
Open
DanielEScherzer wants to merge 1 commit into
Open
DanielEScherzer wants to merge 1 commit into
DanielEScherzer wants to merge 1 commit into
Conversation
…mode` When converting an object into a string for `write_seek_mode`, don't allow the target stream to be closed, otherwise it could trigger a use-after-free or silently reuse the stream.
iliaal
reviewed
Nov 11, 2026
| } | ||
|
|
||
| if (read_write & PHP_STREAM_FILTER_WRITE) { | ||
| bool originally_no_fclose = stream->flags & PHP_STREAM_FLAG_NO_FCLOSE; |
Member
There was a problem hiding this comment.
The read chain has the same problem, stream_filter_append($s, 'convert.base64-encode', STREAM_FILTER_READ, ['write_seek_mode' => $obj]) still frees the stream, so the guard needs to wrap both branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting an object into a string for
write_seek_mode, don't allow the target stream to be closed, otherwise it could trigger a use-after-free or silently reuse the stream.