Repository navigation
Conversation
Since b1242c3 a server stream seeded from a session stream shares the parent's SSL_CTX and ignores its own context options. The SNI callback registered on that context looks up the certificate table of the stream doing the handshake, but the table was left only on the parent, so the child always served the default certificate. Give the child its own table that references the parent's per-name contexts.
bukka
force-pushed
the
openssl_shared_ctx_sni
branch
from
November 11, 2026 18:00
412e114 to
91ad65f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since b1242c3 a server stream seeded from a session stream shares the parent's
SSL_CTXand ignores its own context options. The SNI callback registered on that context looks upsni_certsof the stream doing the handshake, but the table stayed only on the parent, so the child always served the default certificate instead of the one matching the requested name.This gives the child its own table that references the parent's per-name contexts (
SSL_CTX_up_ref), so it also stays valid when the parent is closed first. It follows the same approach as the ALPN list copy in GH-25211.Only 8.6 is affected. In 8.5 a server stream with a session stream still created its own context from its own options.